Skip to content

Repository navigation

test: isolate native verification protocol from Windows ACL startup - #676

Merged
efraespada merged 1 commit into
developfrom
bugfix/675-windows-native-verification-protocol-tests-intermittently-time-out-on-real-acl-setup
Oct 23, 2026
Merged

test: isolate native verification protocol from Windows ACL startup#676
efraespada merged 1 commit into
developfrom
bugfix/675-windows-native-verification-protocol-tests-intermittently-time-out-on-real-acl-setup

Conversation

@efraespada

@efraespada efraespada commented Oct 23, 2026 •
edited by vypbot
Loading

Copy link
Copy Markdown
Member

The protocol tests now mock Windows ACL process calls so sequential candidate verification stays within Jest’s unchanged five-second test budget. Real ACL behavior remains covered by dedicated Windows runtime and native platform acceptance tests.

What changed

  • Mocked ACL setup and verification in the native verification protocol test suite while keeping profiles, environment filtering, Git snapshots, and candidate ordering real.
  • Kept real Windows ACL enforcement coverage in the Windows runtime and native platform acceptance tests.

Validation

  • A controlled slow-ACL diagnostic reproduced the original 5,000 ms timeout before the change.
  • Both affected cases passed three consecutive diagnostic runs within the five-second limit, at 1,493–1,699 ms per case.
  • Native verification and environment suites: 155 tests passed.
  • Required commit hooks passed: build, 710 suites and 11,890 tests, and lint; 35 existing platform skips.
  • Typecheck and Graphify AST update passed.

Closes #675

@vypbot
vypbot self-requested a review October 23, 2026 09:56
@vypbot vypbot added this to vypdev Oct 23, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 23, 2026
@vypbot
vypbot changed the base branch from develop to master October 23, 2026 09:56
@efraespada efraespada linked an issue Oct 23, 2026 that may be closed by this pull request
🐛🧑‍💻 - Windows native verification protocol tests intermittently time out on real ACL setup #675
Closed
1 task done
@vypbot
vypbot changed the base branch from master to develop October 23, 2026 09:56
@vypbot vypbot added size: XS Extra small task with minimal effort required. 25% Progress: 25% labels Oct 23, 2026
@vypbot

vypbot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 0746ff0.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: Evidence passed; a human reviewer must decide.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 0746ff0779d0; base: da0abb4fc993; reason: recommend-mode.

@codecov-commenter

codecov-commenter commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (274db40) to head (0746ff0).
⚠️ Report is 1634 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
+ Coverage    90.94%   94.13%   +3.19%     
===========================================
  Files          135      974     +839     
  Lines         6251    31637   +25386     
  Branches      1338     9290    +7952     
===========================================
+ Hits          5685    29782   +24097     
- Misses         172      715     +543     
- Partials       394     1140     +746

see 1041 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit e69ff6a into develop Oct 23, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 23, 2026
This was referenced Oct 23, 2026
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vypbot vypbot Awaiting requested review from vypbot

Assignees

@efraespada efraespada

Labels

25% Progress: 25% size: XS Extra small task with minimal effort required. state:verified

Projects

vypdev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Windows native verification protocol tests intermittently time out on real ACL setup

3 participants

@efraespada @vypbot @codecov-commenter